Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESLint errors #6201

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix ESLint errors #6201

wants to merge 2 commits into from

Conversation

dhruvisompura
Copy link
Contributor

As part of merging 1.96 from upstream, ESLint was switched to use a flat config which we did not have setup. As a result, React linting from eslint-plugin-react and eslint-plugin-react-hooks were no longer configured for Positron. This problem was addressed in #6172.

During the time period between merging 1.96 from upstream and #6172 being merged into main, we had uncaught React linting errors get pushed to main.

This PR aims to resolve the ESLint errors for all *.tsx files.

To only see ESLint errors the following command can be run : npx eslint **/*.tsx --quiet

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

Copy link

github-actions bot commented Jan 31, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant