add missing esm modules and help.html to reh-web #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
jmcphers
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Verified that this builds cleanly and includes help.html as well as files from esm-package-dependencies. Thanks @sharon-wang!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
New Features
Bug Fixes
QA Notes
These files should no longer be missing, so Positron should now load in Workbench.
I also noticed that help.html was missing, which was preventing the Help Pane from working. Opening Help for R and Python from a Console should now work:
R Console
?irisPython Console
?print