Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For testing purposes, add Data Explorer Clear Column Sorting action to Editor Actions (EditorTitle menu) #6010

Merged

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Jan 15, 2025

Description

As part of #2085, #5361 has been addressed. This means that the Data Explorer action bar has been removed and its actions (Clear Column Sorting and Summary Layout) have been moved to the Editor Action Bar.

At the moment, the user can decide whether to use Editor Actions or the Editor Action Bar. When the user decides to use Editor Actions, this PR adds the Clear Column Sorting action in the EditorTitle menu so that the feature can be accessed in end-to-end tests.

Here's how Clear Column Sorting looks in Editor Actions:

image

And here's how Clear Column Sorting looks on the Editor Action Bar:

image

QA Notes

Tests:
@:editor-action-bar
@:data-explorer

Note that when the Clear Column Sorting action appears in Editor Actions, its title is not displayed because that would take up too much room.

Copy link

github-actions bot commented Jan 15, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:editor-action-bar @:data-explorer

readme  valid tags

@softwarenerd softwarenerd requested a review from midleman January 15, 2025 21:32
Copy link
Collaborator

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on macOS clear sort button appeared on editor title menu and functioned when a sort had been applied to clear it.

@softwarenerd softwarenerd changed the title For testing purposes, add clear column sorting to the editor title menu For testing purposes, add Data Explorer Clear Column Sorting action to Editor Actions (EditorTitle menu) Jan 15, 2025
@softwarenerd softwarenerd merged commit c1abd1f into main Jan 16, 2025
9 checks passed
@softwarenerd softwarenerd deleted the feature/add-clear-column-sorting-to-editor-title-menu branch January 16, 2025 02:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants