-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path completions #6002
Fix path completions #6002
Conversation
E2E Tests 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working as expected in console, .py, and .ipynb 🎉 using text_edit
makes a lot of sense for this scenario!
assert_has_path_completion('"my-notebooks.new/weather"', "-report.ipynb") | ||
assert_has_path_completion('"my-notebooks.new/weather-report"', ".ipynb") | ||
assert_has_path_completion('"my-notebooks.new/weather-report."', "ipynb") | ||
assert_has_path_completion('"my-notebooks.new/weather-report.ipynb"', "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests!
Addresses #5193.
Release Notes
New Features
Bug Fixes
QA Notes
See the linked issue.