Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path completions #6002

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Fix path completions #6002

merged 5 commits into from
Jan 16, 2025

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Jan 15, 2025

Addresses #5193.

Release Notes

New Features

  • N/A

Bug Fixes

QA Notes

See the linked issue.

Copy link

github-actions bot commented Jan 15, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

isabelizimm
isabelizimm previously approved these changes Jan 15, 2025
Copy link
Contributor

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected in console, .py, and .ipynb 🎉 using text_edit makes a lot of sense for this scenario!

austin3dickey
austin3dickey previously approved these changes Jan 15, 2025
assert_has_path_completion('"my-notebooks.new/weather"', "-report.ipynb")
assert_has_path_completion('"my-notebooks.new/weather-report"', ".ipynb")
assert_has_path_completion('"my-notebooks.new/weather-report."', "ipynb")
assert_has_path_completion('"my-notebooks.new/weather-report.ipynb"', "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests!

@seeM seeM dismissed stale reviews from austin3dickey and isabelizimm via d10f7bf January 16, 2025 11:44
@seeM seeM merged commit 202cbd1 into main Jan 16, 2025
15 checks passed
@seeM seeM deleted the 5193-fix-path-completions branch January 16, 2025 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@seeM
Copy link
Contributor Author

seeM commented Jan 16, 2025

Oops, I accidentally merged a43b8fd here when it should have been in #6018. CI is green though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants