Fix lightning and torch._dynamo
#5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
isabelizimm
reviewed
Jan 14, 2025
| @@ -8,6 +8,7 @@ hvplot==0.8.0 ; python_version < '3.9' | |||
| ibis-framework[duckdb]==9.5.0; python_version >= '3.10' | |||
| ipykernel==6.29.5 | |||
| ipywidgets==8.1.5 | |||
| lightning==2.5.0.post0 | |||
There was a problem hiding this comment.
we do some tests on Python 3.8 still, and it looks like the last version where lightning supported 3.8 is 2.3.2. I'd like to keep some 3.8 tests, but I think it's okay to have them just be the nightly ones.
There was a problem hiding this comment.
Ah good point. I've updated to support Python 3.8
austin3dickey
previously approved these changes
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5879. I confirmed that the test fails before pinning
typing-extensions.I haven't dug further into why this happens or how to fix it at the level of
typing-extensions. We may need to do that in future if we encounter this again.Note that this PR also updated a few other vendored packages. The
pygmentsupdate required a tiny change to one of our Help-related tests.Release Notes
New Features
Bug Fixes
torch._dynamo, and thereforelightning(Positron can't load lightning in Python 3.11.10 #5879).QA Notes
Try to
import lightningin a Python console. Note that you will have to rerunnpm installin thepositron-pythonextension to install the new vendored package versions.