Format with ruff 0.9.0 #5930
Merged
Format with ruff 0.9.0 #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
austin3dickey
approved these changes
Jan 9, 2025
isabelizimm
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks! Have we discussed pinning ruff to avoid surprises like this?
We have, I sort of thought this was pinned actually 😅 we don't see a ton of churn, so I would rather leave it as-is and just do these small incremental updates rather than managing the pin-and-remember-to-update dance
wesm
approved these changes
Jan 9, 2025
+1 this is actually the first error I've seen introduced by a new ruff version! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing due to a new ruff version (example). The changes seem good though.