Add Boolean filters to the Data Explorer #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
changed the title
jmcphers
force-pushed
the
feature/boolean-filter-ui
branch
from
0fdcaa1 to
f444e43
Compare
nstrayer
approved these changes
May 2, 2024
Comment on lines
+343
to
+350
| conditionEntries.push(new DropDownListBoxItem({ | ||
| identifier: RowFilterDescrType.IS_TRUE, | ||
| title: localize( | ||
| 'positron.addEditRowFilter.conditionIsTrue', | ||
| "is true" | ||
| ), | ||
| value: RowFilterDescrType.IS_TRUE | ||
| })); |
There was a problem hiding this comment.
The fact these are all the same makes me wonder if a new class could be made for each condition ala how ContextKeyExpression works.
E.g.
export class DropDownListBoxTrue extends DropDownListBoxItem<RowFilterDescrType.IS_TRUE, string> {
constructor() {
super(
{
identifier: RowFilterDescrType.IS_TRUE,
title: localize(
'positron.addEditRowFilter.conditionIsTrue',
"is true"
),
value: RowFilterDescrType.IS_TRUE
});
}
}There was a problem hiding this comment.
Not super applicable to this PR though
There was a problem hiding this comment.
This whole file is chock full of code duplication. I did a little refactoring a week or two ago to reduce some of it, but it would be good to modularize and make the list of "what filters are supported for each type" more declarative / easier to edit and less ad hoc. Same with the row filter descriptor classes which feel more verbose than is needed
|
@nstrayer thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Creates "is true" and "is false" filter types and supporting UI code. Part of #2372. Addresses #2946.
Approach
Update comm contract; add UI for true/false filters; implementation in Python.
QA Notes
"Is true" and "Is false" test for these exact values rather than "truthy" or "falsy" values (e.g. Null/NA should not be considered true or false).
There is a related bug (which I did not attempt to fix) in the Python backend: currently, a column must contain at least one missing value in order for it to be marked as a boolean. #2950