Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start notebook sessions in the notebook's parent directory #2917

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jmcphers
Copy link
Collaborator

Intent

Addresses #2648.

image

Approach

When starting the hidden terminal backing an R or Python Jupyter session, we now use the notebook's parent path (if known) as the process's current working directory.

QA Notes

I also dropped the full path from the notebook session names (because it was super unwieldy). Notebook session names are now just the notebook file's name.

@jmcphers jmcphers requested a review from seeM April 27, 2024 00:09
@petetronic
Copy link
Collaborator

Tested this branch with a new notebook that I created in a subdir of my workspace and confirmed %pwd magic run in a cell reported the working directory was the parent of the new notebook.

@jmcphers jmcphers merged commit f09e2e1 into main Apr 29, 2024
1 check passed
@jmcphers jmcphers deleted the feature/notebook-working-dirc branch April 29, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants