Add status icons to Data Explorer #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For posterity - the eventual goal is to animate these with CSS:
|
This change includes the CSS animations. :-) |
|
Ack! My apologies - thanks Jonathan! |
nstrayer
approved these changes
Apr 29, 2024
| animation: rotate-computing 1.5s linear infinite; | ||
| } | ||
|
|
||
| @keyframes rotate-computing { |
There was a problem hiding this comment.
Should this be name-scoped a bit more specific? I feel like it wouldn't be unreasonable to have a collision. (Although a collision would probably want to be the exact same definition.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Updates the status bar on the Data Explorer with an icon representing its current state (idle, computing, or disconnected).
Addresses #2914.
Approach
Add icons and design.
QA Notes
This change is purely visual.