Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'get_supported_features' RPC for data explorer backend #2643

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Apr 3, 2024

Addresses #2201. This is just a starting point and will be refined to add more granular feature flagging, but wanted to break the seal on this.

Summary

  • Adds feature flags for search_schema, set_row_filters, and get_column_profiles
  • For filtering and profiles, indicates which row filter types / profile types are supported
  • Return basic feature flags for pandas objects (each type of data structure can return different feature flags, so it isn't necessarily global to the runtime but rather local to the particular data type)
  • Extracted row filter type and profile type into shared enums

Also addresses #2599 (renaming search_filter_params.type to search_type)

Associated amalthea PR: posit-dev/ark#298

@wesm wesm requested a review from jmcphers April 3, 2024 23:25
@@ -332,7 +349,7 @@ class SearchFilterParams(BaseModel):
Parameters for the 'search' filter type
"""

type: SearchFilterParamsType = Field(
search_type: SearchFilterType = Field(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this too!

@wesm wesm merged commit 8c7167c into main Apr 3, 2024
23 checks passed
@wesm wesm deleted the feature/de-feature-flags branch April 3, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants