Download Ark builds for Windows #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Dec 11, 2023
Comment on lines
-206
to
+212
| await executeCommand(`unzip -o ` + | ||
| `${path.join('resources', 'ark', 'ark.zip')}` + | ||
| ` -d ` + | ||
| `${path.join('resources', 'ark')}`); | ||
| console.log(stdout); | ||
| if (stderr) { | ||
| console.error(stderr); | ||
| } else { | ||
| await decompress(zipFileDest, arkDir).then(files => { |
There was a problem hiding this comment.
Using decompress() seemed like the easiest way to get platform independent unzipping? Open to other ideas. But unzip is not natively on Windows, at least it didn't work on my VM like this.
extensions/positron-r/yarn.lock
Outdated
There was a problem hiding this comment.
I'm not entirely sure why the yarn.lock changed so much
There was a problem hiding this comment.
Probably decompress has a large-ish dependency tree.
DavisVaughan
changed the title
jmcphers
approved these changes
Dec 11, 2023
extensions/positron-r/yarn.lock
Outdated
There was a problem hiding this comment.
Probably decompress has a large-ish dependency tree.
DavisVaughan
force-pushed
the
feature/windows-ark-downloads
branch
from
e0d8e43 to
d2c0551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #159
Companion to posit-dev/ark#175
I have tested that Positron + Ark works on Windows with this in the following setups:
amalthea/, Positron finds itresources/ark/, uses it from thereyarn gulp vscodelocally and then running the resulting release