Merge remote-tracking branch 'upstream/main'

Lead-authored-by: Jonathan McPherson <[email protected]> Co-authored-by: positron-bot[bot] <173392469+positron-bot[bot]@users.noreply.github.com>
posit-dev · Sep 13, 2022 · 6dafb79 · 6dafb79
1 parent 7d79515
commit 6dafb79
Show file tree

Hide file tree

Showing 956 changed files with 18,140 additions and 13,726 deletions.
diff --git a/build/lib/eslint/code-import-patterns.ts → .eslintplugin/code-import-patterns.ts b/build/lib/eslint/code-import-patterns.ts → .eslintplugin/code-import-patterns.ts
@@ -6,10 +6,10 @@
 import * as eslint from 'eslint';
 import { TSESTree } from '@typescript-eslint/experimental-utils';
 import * as path from 'path';
-import * as minimatch from 'minimatch';
+import minimatch from 'minimatch';
 import { createImportRuleListener } from './utils';
 
-const REPO_ROOT = path.normalize(path.join(__dirname, '../../../'));
+const REPO_ROOT = path.normalize(path.join(__dirname, '../'));
 
 interface ConditionalPattern {
 	when?: 'hasBrowser' | 'hasNode' | 'test';

diff --git a/build/lib/eslint/code-layering.ts → .eslintplugin/code-layering.ts b/build/lib/eslint/code-layering.ts → .eslintplugin/code-layering.ts
diff --git a/...d/lib/eslint/code-no-look-behind-regex.ts → .eslintplugin/code-no-look-behind-regex.ts b/...d/lib/eslint/code-no-look-behind-regex.ts → .eslintplugin/code-no-look-behind-regex.ts
diff --git a/...slint/code-no-nls-in-standalone-editor.ts → ...lugin/code-no-nls-in-standalone-editor.ts b/...slint/code-no-nls-in-standalone-editor.ts → ...lugin/code-no-nls-in-standalone-editor.ts
diff --git a/...d/lib/eslint/code-no-standalone-editor.ts → .eslintplugin/code-no-standalone-editor.ts b/...d/lib/eslint/code-no-standalone-editor.ts → .eslintplugin/code-no-standalone-editor.ts
diff --git a/build/lib/eslint/code-no-test-only.ts → .eslintplugin/code-no-test-only.ts b/build/lib/eslint/code-no-test-only.ts → .eslintplugin/code-no-test-only.ts
diff --git a/.../eslint/code-no-unexternalized-strings.ts → ...tplugin/code-no-unexternalized-strings.ts b/.../eslint/code-no-unexternalized-strings.ts → ...tplugin/code-no-unexternalized-strings.ts
diff --git a/.../lib/eslint/code-no-unused-expressions.ts → .eslintplugin/code-no-unused-expressions.ts b/.../lib/eslint/code-no-unused-expressions.ts → .eslintplugin/code-no-unused-expressions.ts
diff --git a/build/lib/eslint/code-translation-remind.ts → .eslintplugin/code-translation-remind.ts b/build/lib/eslint/code-translation-remind.ts → .eslintplugin/code-translation-remind.ts
diff --git a/.eslintplugin/index.js b/.eslintplugin/index.js
@@ -0,0 +1,12 @@
+const glob = require('glob');
+const path = require('path');
+
+require('ts-node').register({ experimentalResolver: true, transpileOnly: true });
+
+// Re-export all .ts files as rules
+const rules = {};
+glob.sync(`${__dirname}/*.ts`).forEach((file) => {
+	rules[path.basename(file, '.ts')] = require(file);
+});
+
+exports.rules = rules;
diff --git a/.eslintplugin/tsconfig.json b/.eslintplugin/tsconfig.json
@@ -0,0 +1,26 @@
+{
+	"compilerOptions": {
+		"target": "es2020",
+		"lib": [
+			"ES2020"
+		],
+		"module": "commonjs",
+		"esModuleInterop": true,
+		"alwaysStrict": true,
+		"allowJs": true,
+		"strict": true,
+		"exactOptionalPropertyTypes": false,
+		"useUnknownInCatchVariables": false,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
+		"newLine": "lf",
+		"noEmit": true
+	},
+	"include": [
+		"**/*.ts",
+		"**/*.js"
+	],
+	"exclude": [
+		"node_modules/**"
+	]
+}
diff --git a/build/lib/eslint/utils.ts → .eslintplugin/utils.ts b/build/lib/eslint/utils.ts → .eslintplugin/utils.ts
diff --git a/build/lib/eslint/vscode-dts-cancellation.ts → .eslintplugin/vscode-dts-cancellation.ts b/build/lib/eslint/vscode-dts-cancellation.ts → .eslintplugin/vscode-dts-cancellation.ts
diff --git a/build/lib/eslint/vscode-dts-create-func.ts → .eslintplugin/vscode-dts-create-func.ts b/build/lib/eslint/vscode-dts-create-func.ts → .eslintplugin/vscode-dts-create-func.ts
diff --git a/build/lib/eslint/vscode-dts-event-naming.ts → .eslintplugin/vscode-dts-event-naming.ts b/build/lib/eslint/vscode-dts-event-naming.ts → .eslintplugin/vscode-dts-event-naming.ts
diff --git a/...lib/eslint/vscode-dts-interface-naming.ts → .eslintplugin/vscode-dts-interface-naming.ts b/...lib/eslint/vscode-dts-interface-naming.ts → .eslintplugin/vscode-dts-interface-naming.ts
diff --git a/...lib/eslint/vscode-dts-literal-or-types.ts → .eslintplugin/vscode-dts-literal-or-types.ts b/...lib/eslint/vscode-dts-literal-or-types.ts → .eslintplugin/vscode-dts-literal-or-types.ts
diff --git a/.../lib/eslint/vscode-dts-provider-naming.ts → .eslintplugin/vscode-dts-provider-naming.ts b/.../lib/eslint/vscode-dts-provider-naming.ts → .eslintplugin/vscode-dts-provider-naming.ts
diff --git a/.../lib/eslint/vscode-dts-region-comments.ts → .eslintplugin/vscode-dts-region-comments.ts b/.../lib/eslint/vscode-dts-region-comments.ts → .eslintplugin/vscode-dts-region-comments.ts
diff --git a/build/lib/eslint/vscode-dts-use-thenable.ts → .eslintplugin/vscode-dts-use-thenable.ts b/build/lib/eslint/vscode-dts-use-thenable.ts → .eslintplugin/vscode-dts-use-thenable.ts
diff --git a/...b/eslint/vscode-dts-vscode-in-comments.ts → ...ntplugin/vscode-dts-vscode-in-comments.ts b/...b/eslint/vscode-dts-vscode-in-comments.ts → ...ntplugin/vscode-dts-vscode-in-comments.ts
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -8,7 +8,8 @@
 	"plugins": [
 		"@typescript-eslint",
 		"jsdoc",
-		"header"
+		"header",
+		"local"
 	],
 	"rules": {
 		"constructor-super": "warn",
@@ -61,17 +62,17 @@
 				]
 			}
 		],
-		"code-no-unused-expressions": [
+		"local/code-no-unused-expressions": [
 			"warn",
 			{
 				"allowTernary": true
 			}
 		],
-		"code-translation-remind": "warn",
-		"code-no-nls-in-standalone-editor": "warn",
-		"code-no-standalone-editor": "warn",
-		"code-no-unexternalized-strings": "warn",
-		"code-layering": [
+		"local/code-translation-remind": "warn",
+		"local/code-no-nls-in-standalone-editor": "warn",
+		"local/code-no-standalone-editor": "warn",
+		"local/code-no-unexternalized-strings": "warn",
+		"local/code-layering": [
 			"warn",
 			{
 				"common": [],
@@ -122,8 +123,8 @@
 				"**/*.test.ts"
 			],
 			"rules": {
-				"code-no-test-only": "error",
-				"code-no-unexternalized-strings": "off"
+				"local/code-no-test-only": "error",
+				"local/code-no-unexternalized-strings": "off"
 			}
 		},
 		{
@@ -132,14 +133,14 @@
 				"**/vscode.proposed.*.d.ts"
 			],
 			"rules": {
-				"vscode-dts-create-func": "warn",
-				"vscode-dts-literal-or-types": "warn",
-				"vscode-dts-interface-naming": "warn",
-				"vscode-dts-cancellation": "warn",
-				"vscode-dts-use-thenable": "warn",
-				"vscode-dts-region-comments": "warn",
-				"vscode-dts-vscode-in-comments": "warn",
-				"vscode-dts-provider-naming": [
+				"local/vscode-dts-create-func": "warn",
+				"local/vscode-dts-literal-or-types": "warn",
+				"local/vscode-dts-interface-naming": "warn",
+				"local/vscode-dts-cancellation": "warn",
+				"local/vscode-dts-use-thenable": "warn",
+				"local/vscode-dts-region-comments": "warn",
+				"local/vscode-dts-vscode-in-comments": "warn",
+				"local/vscode-dts-provider-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -154,7 +155,7 @@
 						]
 					}
 				],
-				"vscode-dts-event-naming": [
+				"local/vscode-dts-event-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -200,8 +201,8 @@
 				"src/**/*.ts"
 			],
 			"rules": {
-				"code-no-look-behind-regex": "warn",
-				"code-import-patterns": [
+				"local/code-no-look-behind-regex": "warn",
+				"local/code-import-patterns": [
 					"warn",
 					{
 						// imports that are allowed in all files of layers:
@@ -576,7 +577,7 @@
 				"test/**/*.ts"
 			],
 			"rules": {
-				"code-import-patterns": [
+				"local/code-import-patterns": [
 					"warn",
 					{
 						"target": "test/smoke/**",

diff --git a/.github/classifier.json b/.github/classifier.json
@@ -1,6 +1,6 @@
 {
-	"$schema": "https://raw.githubusercontent.com/microsoft/vscode-github-triage-actions/master/classifier-deep/apply/apply-labels/deep-classifier-config.schema.json",
-	"vacation": ["RMacfarlane", "eamodio"],
+	"$schema": "https://raw.githubusercontent.com/microsoft/vscode-github-triage-actions/stable/classifier-deep/apply/apply-labels/deep-classifier-config.schema.json",
+	"vacation": [],
 	"assignees": {
 		"nameToOverrideAccuracyOf": {"accuracy": 0.8}
 	},
@@ -85,7 +85,7 @@
 		"html": {"assign": ["aeschli"]},
 		"i18n": {"assign": []},
 		"icon-brand": {"assign": []},
-		"icons-product": {"assign": ["misolori"]},
+		"icons-product": {"assign": ["daviddossett"]},
 		"inlay-hints": {"assign": ["jrieken", "hediet"]},
 		"inline-completions": {"assign": ["hediet"]},
 		"install-update": {"assign": []},
@@ -132,7 +132,7 @@
 		"rename": {"assign": ["jrieken"]},
 		"scm": {"assign": ["lszomoru"]},
 		"screencast-mode": {"assign": ["lszomoru"]},
-		"search": {"assign": ["roblourens"]},
+		"search": {"assign": ["roblourens", "andreamah"]},
 		"search-editor": {"assign": ["roblourens"]},
 		"search-replace": {"assign": ["sandy081"]},
 		"semantic-tokens": {"assign": ["alexdima", "aeschli"]},
@@ -158,7 +158,7 @@
 		"undo-redo": {"assign": ["alexdima"]},
 		"unit-test": {"assign": []},
 		"uri": {"assign": ["jrieken"]},
-		"ux": {"assign": ["misolori"]},
+		"ux": {"assign": ["daviddossett"]},
 		"variable-resolving": {"assign": []},
 		"vscode-build": {"assign": []},
 		"web": {"assign": []},

diff --git a/.github/commands.json b/.github/commands.json
@@ -11,6 +11,18 @@
 		"action": "updateLabels",
 		"addLabel": "*question"
 	},
+	{
+		"type": "comment",
+		"name": "dev-question",
+		"allowUsers": [
+			"cleidigh",
+			"usernamehw",
+			"gjsjohnmurray",
+			"IllusionMH"
+		],
+		"action": "updateLabels",
+		"addLabel": "*dev-question"
+	},
 	{
 		"type": "label",
 		"name": "*question",
@@ -23,7 +35,7 @@
 		"name": "*dev-question",
 		"action": "close",
 		"reason": "not_planned",
-		"comment": "We have a great developer community [over on slack](https://aka.ms/vscode-dev-community) where extension authors help each other. This is a great place for you to ask questions and find support.\n\nHappy Coding!"
+		"comment": "We have a great extension developer community over on [GitHub discussions](https://github.com/microsoft/vscode-discussions/discussions) and [Slack](https://aka.ms/vscode-dev-community) where extension authors help each other. This is a great place for you to ask questions and find support.\n\nHappy Coding!"
 	},
 	{
 		"type": "label",
@@ -63,7 +75,7 @@
 		"name": "*caused-by-extension",
 		"action": "close",
 		"reason": "not_planned",
-		"comment": "This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the [marketplace](https://aka.ms/vscodemarketplace) for VS Code. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting).\n\nHappy Coding!"
+		"comment": "This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the [marketplace](https://aka.ms/vscodemarketplace) for VS Code. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting). If you don't know which extension is causing the problem, you can run `Help: Start extension bisect` from the command palette (F1) to help identify the problem extension.\n\nHappy Coding!"
 	},
 	{
 		"type": "label",
@@ -72,21 +84,6 @@
 		"reason": "not_planned",
 		"comment": "The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our [issue reporting guidelines](https://aka.ms/vscodeissuereporting).\n\nHappy Coding!"
 	},
-	{
-		"type": "label",
-		"name": "notebook",
-		"regex": "notebook.*",
-		"assign": [
-			"rebornix"
-		]
-	},
-	{
-		"type": "label",
-		"name": "notebook-triage",
-		"regex": "notebook.*",
-		"action": "updateLabels",
-		"addLabel": "notebook-triage"
-	},
 	{
 		"type": "label",
 		"name": "L10N",

diff --git a/.mailmap b/.mailmap
@@ -1,6 +1,4 @@
-Eric Amodio <[email protected]> Eric Amodio <[email protected]>
-Eric Amodio <[email protected]> Eric Amodio <[email protected]>
 Daniel Imms <[email protected]> Daniel Imms <[email protected]>
-Tanha Kabir <[email protected]> Tanha Kabir <[email protected]>
 Raymond Zhao <[email protected]>
 Tyler Leonhardt <[email protected]> Tyler Leonhardt <[email protected]>
+João Moreno <[email protected]> João Moreno <[email protected]>
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -67,6 +67,7 @@
 			"name": "Attach to Main Process",
 			"timeout": 30000,
 			"port": 5875,
+			"continueOnAttach": true,
 			"outFiles": [
 				"${workspaceFolder}/out/**/*.js"
 			],
@@ -237,7 +238,7 @@
 			"cleanUp": "wholeBrowser",
 			"urlFilter": "*workbench.html*",
 			"runtimeArgs": [
-				"--inspect=5875",
+				"--inspect-brk=5875",
 				"--no-cached-data",
 				"--crash-reporter-directory=${workspaceFolder}/.profile-oss/crashes",
 				// for general runtime freezes: https://github.com/microsoft/vscode/issues/127861#issuecomment-904144910
@@ -468,10 +469,9 @@
 			"type": "node",
 			"request": "launch",
 			"name": "Launch Smoke Test",
-			"program": "${workspaceFolder}/test/smoke/out/main.js",
+			"program": "${workspaceFolder}/test/smoke/test/index.js",
 			"cwd": "${workspaceFolder}/test/smoke",
 			"timeout": 240000,
-			"port": 9999,
 			"args": [
 				"-l",
 				"${workspaceFolder}/.build/electron/Code - OSS.app/Contents/MacOS/Electron"
@@ -512,9 +512,10 @@
 			}
 		},
 		{
-			"name": "Search and Renderer processes",
+			"name": "Search, Renderer, and Main processes",
 			"configurations": [
 				"Launch VS Code Internal",
+				"Attach to Main Process",
 				"Attach to Search Process"
 			],
 			"presentation": {
@@ -523,9 +524,10 @@
 			}
 		},
 		{
-			"name": "Renderer and Extension Host processes",
+			"name": "Renderer, Extension Host, and Main processes",
 			"configurations": [
 				"Launch VS Code Internal",
+				"Attach to Main Process",
 				"Attach to Extension Host"
 			],
 			"presentation": {
@@ -556,10 +558,11 @@
 			}
 		},
 		{
-			"name": "Launch VS Code",
+			"name": "Renderer and Main processes",
 			"stopAll": true,
 			"configurations": [
 				"Launch VS Code Internal",
+				"Attach to Main Process"
 			],
 			"preLaunchTask": "Ensure Prelaunch Dependencies"
 		},

diff --git a/.vscode/notebooks/api.github-issues b/.vscode/notebooks/api.github-issues
@@ -7,7 +7,7 @@
   {
     "kind": 2,
     "language": "github-issues",
-    "value": "$repo=repo:microsoft/vscode\n$milestone=milestone:\"August 2022\""
+    "value": "$repo=repo:microsoft/vscode\n$milestone=milestone:\"September 2022\""
   },
   {
     "kind": 1,

diff --git a/.vscode/notebooks/my-endgame.github-issues b/.vscode/notebooks/my-endgame.github-issues
@@ -157,7 +157,7 @@
   {
     "kind": 2,
     "language": "github-issues",
-    "value": "$REPOS $MILESTONE -$MINE is:issue is:closed sort:updated-asc label:bug -label:unreleased -label:verified -label:z-author-verified -label:on-testplan -label:*duplicate -label:duplicate -label:invalid -label:*as-designed -label:error-telemetry -label:verification-steps-needed -label:verification-found -author:aeschli -author:alexdima -author:alexr00 -author:AmandaSilver -author:bamurtaugh -author:bpasero -author:chrisdias -author:chrmarti -author:Chuxel -author:claudiaregio -author:connor4312 -author:dbaeumer -author:deepak1556 -author:devinvalenciano -author:digitarald -author:DonJayamanne -author:dynamicwebpaige -author:eamodio -author:egamma -author:fiveisprime -author:greazer -author:gregvanl -author:hediet -author:IanMatthewHuff -author:isidorn -author:ItalyPaleAle -author:JacksonKearl -author:joaomoreno -author:joyceerhl -author:jrieken -author:karrtikr-author:kieferrm -author:lramos15 -author:lszomoru -author:meganrogge -author:misolori -author:mjbvz -author:ornellaalt -author:orta -author:rchiodo -author:rebornix -author:roblourens -author:rzhao271 -author:sana-ajani -author:sandy081 -author:sbatten -author:stevencl -author:tanhakabir -author:TylerLeonhardt -author:Tyriar -author:weinand -author:kimadeline -author:amunger"
+    "value": "$REPOS $MILESTONE -$MINE is:issue is:closed sort:updated-asc label:bug -label:unreleased -label:verified -label:z-author-verified -label:on-testplan -label:*duplicate -label:duplicate -label:invalid -label:*as-designed -label:error-telemetry -label:verification-steps-needed -label:verification-found -author:aeschli -author:alexdima -author:alexr00 -author:AmandaSilver -author:andreamah -author:bamurtaugh -author:bpasero -author:chrisdias -author:chrmarti -author:Chuxel -author:claudiaregio -author:connor4312 -author:dbaeumer -author:deepak1556 -author:devinvalenciano -author:digitarald -author:DonJayamanne -author:egamma -author:fiveisprime -author:gregvanl -author:hediet -author:IanMatthewHuff -author:isidorn -author:joaomoreno -author:joyceerhl -author:jrieken -author:karrtikr -author:kieferrm -author:lramos15 -author:lszomoru -author:meganrogge -author:misolori -author:mjbvz -author:rebornix -author:roblourens -author:rzhao271 -author:sandy081 -author:sbatten -author:stevencl -author:tanhakabir -author:TylerLeonhardt -author:Tyriar -author:weinand -author:amunger"
   },
   {
     "kind": 1,

diff --git a/.vscode/notebooks/my-work.github-issues b/.vscode/notebooks/my-work.github-issues
@@ -7,7 +7,7 @@
   {
     "kind": 2,
     "language": "github-issues",
-    "value": "// list of repos we work in\n$repos=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce\n\n// current milestone name\n$milestone=milestone:\"August 2022\""
+    "value": "// list of repos we work in\n$repos=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce\n\n// current milestone name\n$milestone=milestone:\"September 2022\""
   },
   {
     "kind": 1,

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -41,11 +41,6 @@
 			}
 		}
 	],
-	"eslint.options": {
-		"rulePaths": [
-			"./build/lib/eslint"
-		]
-	},
 	"typescript.tsdk": "node_modules/typescript/lib",
 	"npm.exclude": "**/extensions/**",
 	"npm.packageManager": "yarn",

diff --git a/README.md b/README.md
@@ -43,6 +43,7 @@ please see the document [How to Contribute](https://github.com/microsoft/vscode/
 * [Request a new feature](CONTRIBUTING.md)
 * Upvote [popular feature requests](https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc)
 * [File an issue](https://github.com/microsoft/vscode/issues)
+* Connect with the extension author community on [GitHub Discussions](https://github.com/microsoft/vscode-discussions/discussions) or [Slack](https://aka.ms/vscode-dev-community)
 * Follow [@code](https://twitter.com/code) and let us know what you think!
 
 See our [wiki](https://github.com/microsoft/vscode/wiki/Feedback-Channels) for a description of each of these channels and information on some other available community-driven channels.