Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New downloads page #26

Merged
merged 6 commits into from
Dec 3, 2024
Merged

New downloads page #26

merged 6 commits into from
Dec 3, 2024

Conversation

juliasilge
Copy link
Collaborator

@juliasilge juliasilge commented Dec 3, 2024

This PR starts our new page for providing downloads via the https://cdn.posit.co/positron/ URLs.

In the very first initial here, I have this set up via Quarto parameters but we can make this as complicated as we want moving forward, in terms of older releases being available and such.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for positron-posit-co ready!

Name Link
🔨 Latest commit f371649
🔍 Latest deploy log https://app.netlify.com/sites/positron-posit-co/deploys/674f7e1d096e3d0008fe3487
😎 Deploy Preview https://deploy-preview-26--positron-posit-co.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@juliasilge
Copy link
Collaborator Author

juliasilge commented Dec 3, 2024

I set up Plausible analytics for downloads in 28533ee, and according to them, it is all set up correctly (but of course nothing will get counted until we merge this PR with the links).

@juliasilge
Copy link
Collaborator Author

Some next steps after this include:

  • make a button based on the user's OS, like what Quarto has
  • start a page for release notes (see release notes for Quarto which are one page per release and Workbench which are one big page with a heading per release)

@juliasilge juliasilge marked this pull request as ready for review December 3, 2024 21:18
@juliasilge juliasilge requested a review from petetronic December 3, 2024 21:20
Copy link
Contributor

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the preview site and the download links looked good. As Julia mentioned, in a future change we'll have a convenient button, but this is a great first step.

@juliasilge juliasilge merged commit 1b38b33 into main Dec 3, 2024
5 checks passed
@juliasilge juliasilge deleted the add-download-links branch December 3, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants