Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename air.executableLocation and add air.executablePath support #245

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

DavisVaughan
Copy link
Collaborator

@DavisVaughan DavisVaughan commented Feb 20, 2025

Closes #243

  • Renamed air.executableLocation to air.executableStrategy and updated documentation
  • Added "path" option to air.executableStrategy
  • Added air.executablePath

Reworked resolveAirBinaryPath() to be a series of if/else statements so it is extremely clear what all of the fallback behavior combination is. I think this dramatically improves both readability and the logging. I used Rust style Options by adding helpers like airBinaryFromBundled() that return string | undefined, which I think made the main function easier to read

I tested out each of these behaviors locally and am happy with the logging and errors

@DavisVaughan DavisVaughan requested a review from lionel- February 20, 2025 15:07
Copy link
Collaborator

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DavisVaughan DavisVaughan merged commit b933f82 into main Feb 21, 2025
6 checks passed
@DavisVaughan DavisVaughan deleted the feature/executable-strategy branch February 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer tool - air.executableLocation option of "path", and new air.executablePath
2 participants