Rename air.executableLocation
and add air.executablePath
support
#245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #243
air.executableLocation
toair.executableStrategy
and updated documentation"path"
option toair.executableStrategy
air.executablePath
Reworked
resolveAirBinaryPath()
to be a series of if/else statements so it is extremely clear what all of the fallback behavior combination is. I think this dramatically improves both readability and the logging. I used Rust styleOption
s by adding helpers likeairBinaryFromBundled()
that returnstring | undefined
, which I think made the main function easier to readI tested out each of these behaviors locally and am happy with the logging and errors