Disable hugging when the argument is named #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #228 after running this on dplyr code and talking to @lionel- about it
We remain confident that hugging is extremely useful in general, but we think that hugging is mostly useful when the argument in question is not named. For example:
Hugging becomes particularly not-useful in functions that accept 1 or more key/value pairs, like
mutate()
Hugging takes away from the symmetry a little bit, making it hard to scan down the pipeline and see the new variable names of
name =
,name2 =
, andname3 =
. It also makes it a little harder to add a 2nd column expression to that firstmutate()
call, because you have to place your cursor between the))
and then add the,
there.We do think that hugging can be somewhat nice in other dplyr verbs, like
filter()
, where named arguments are not used