Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Successful dry-run built an ARM Windows binary here https://github.com/posit-dev/air/actions/runs/12969634669/job/36173931978, in theory it works? 😆
The way this works is through cross-compilation. GitHub currently only provides x86_64 Windows runners on the free tier, so instead according to axodotdev/cargo-dist#1635 cargo-dist will detect that you are requesting ARM Windows and will automatically:
messense/cargo-xwin
image which brings in https://github.com/rust-cross/cargo-xwin for cross compilation to windows from linux (here is the docker image, its by the owner of cargo-xwin https://hub.docker.com/r/messense/cargo-xwin)I see two reasons this could change on the cargo-dist side going forward:
aarch64-pc-windows-msvc
fromx86_64-pc-windows-msvc
without usingcargo-xwin
axodotdev/cargo-dist#1644 could get implemented, where they use a simpler approach of using GitHub's x86_64 windows machine and cross compile toaarch64-pc-windows-msvc
, which supposedly just works withcargo build --target aarch64-pc-windows-msvc
(Biome actually does this)Regardless, both possibilities would be cargo-dist details and would be nicely abstracted away from us, so all we'd have to do is update cargo-dist to get the changes. And in the meantime as long as cargo-xwin works I'm not mad about using it.