Switch to manually downloading the binary #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Jan 23, 2025
| @@ -72,7 +82,7 @@ jobs: | |||
|
|
|||
| # Upload the extension. | |||
| - name: Upload artifacts | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
I was forced to bump this by github actions
lionel-
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #194
In theory we could use
arch -x86_64 curlon Mac and keep using cargo-dist, but due to axodotdev/cargo-dist#1720 this does not work. I'm not really sure axodotdev/cargo-dist#1720 will get solved, as when I think about this more we are kind of abusing cargo-dist here. It's purpose is really to get you set up to run the tool (so bypassing Rosetta does seem to make sense on their end), all we were using it for is a way to magically download the right one for this platform, but that isn't too hard to set up ourself.This dry run shows this seems to be working right
https://github.com/posit-dev/air/actions/runs/12935503617
I downloaded the x86 mac vsix artifact it created and
fileshows that the air binary bundled in there is indeed the right architecture now. The output from the run on Windows shows that theair.exestill makes it into thebundled/bindirectory correctly.