Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double language server logging #180

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix double language server logging #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccc937f
Don't initialize logging when running the language server
DavisVaughan Jan 17, 2025
79f0176
CHANGELOG bullet
DavisVaughan Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

# Development version

- Fixed an issue where the language server failed to start due to logging
being initialized twice.

# 1.0.0

- Initial public release, yay!
Expand Down
11 changes: 7 additions & 4 deletions crates/air/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ mod logging;
pub mod status;

pub fn run(args: Args) -> anyhow::Result<ExitStatus> {
logging::init_logging(
args.global_options.log_level.unwrap_or_default(),
args.global_options.no_color,
);
if !matches!(args.command, Command::LanguageServer(_)) {
// The language server sets up its own logging
logging::init_logging(
args.global_options.log_level.unwrap_or_default(),
args.global_options.no_color,
);
}

match args.command {
Command::Format(command) => commands::format::format(command),
Expand Down
Loading