Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global --log-level and --no-color CLI options and logging support #155

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

DavisVaughan
Copy link
Collaborator

Closes #140

The cli help file:

Screenshot 2025-01-14 at 3 34 21 PM

Running air format on R source results in a few failures that we see now

Screenshot 2025-01-14 at 3 33 39 PM

@DavisVaughan DavisVaughan requested a review from lionel- January 15, 2025 18:10
/// Disable colored output. To turn colored output off, either set this option or set
/// the environment variable `NO_COLOR` to any non-zero value.
#[arg(long, global = true)]
pub(crate) no_color: bool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe move this to an advanced section in the future. Since we don't have many options it'd be weird to do this now.

@DavisVaughan DavisVaughan merged commit 061b4db into main Jan 17, 2025
4 checks passed
@DavisVaughan DavisVaughan deleted the feature/cli-logs branch January 17, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tracing subscriber in the CLI
2 participants