Use a tracing subscriber for LSP logging #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely isolates it, and also allows us to maintain all logging related logic in `logging.rs`
Right now we don't even have the "compatibility" log layer turned on
- `just test` is silent - `just test-verbose` is noisy and sequential - CI is noisy and sequential and `trace` level
DavisVaughan
force-pushed
the
feature/tracing-logs
branch
from
3f0f720 to
e26893f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #93 for all discussion
I somehow merged it into #80 and rebased #80 on main and it dropped everything from this pr?? I'm not entirely sure what happened but I'm reviving it here.