EE-1120: Feat/registry sync #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s _and_ --help Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
… a feature? Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
…e.ID Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
feat/registry-sync
branch
2 times, most recently
from
51fd35b to
c0b0677
Compare
SvenDowideit
requested review from
DimaSalakhov,
deviantony,
andres-portainer and
cheloRydel
…0, directly into the docker daemon Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
feat/registry-sync
branch
from
c0b0677 to
1359a82
Compare
|
|
||
| edgeKeyFilePath := fmt.Sprintf("%s/%s", agent.DataDirectory, agent.EdgeKeyFile) | ||
|
|
||
| keyFileExists, err := filesystem.FileExists(edgeKeyFilePath) |
There was a problem hiding this comment.
Nitpick: this check seems a bit redundant (and not concurrency-friendly), if the file doesn't exist then filesystem.ReadFromFile() will catch it below anyway.
| err = filesystem.WriteFile(agent.DataDirectory, agent.EdgeKeyFile, []byte(key), 0444) | ||
| if err != nil { | ||
| return err | ||
| // TODO: yeah, we don't know if we got it from the fs, so lets try again :/ |
There was a problem hiding this comment.
Maybe just write the file with os.O_CREATE | os.O_EXCL instead?
There was a problem hiding this comment.
Got a reference for that one in #239
|
Replaced by #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by #250
https://portainer.atlassian.net/browse/EE-1120
just the last commit - the rest if the refactoring from #229