Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Seqr minimiser script #358

Closed
wants to merge 2 commits into from
Closed

Conversation

MattWellie
Copy link
Collaborator

Fixes

  • Script which takes AIP results and minimises for Seqr doesn't 100% fit the expected API
  • Based on this test data which doesn't include 'independent' as an entity, and maps on Individual ID

Proposed Changes

  • Requires a Seqr mapping dictionary to convert CPG IDs to External Participant IDs
  • Removes the Independent attribute from models

This is on hold pending the successful ingestion of the data generated by the script in its current form

Checklist

  • Related Issue created
  • Tests covering new change
  • Linting checks pass

Copy link

@EddieLF EddieLF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once this PR is merged and released you should be able to just call the participant API endpoint for a particular project to get the ext pid to sg id dict easily.

@cassimons cassimons removed their request for review February 22, 2024 20:05
@MattWellie
Copy link
Collaborator Author

I think this has been done in a separate branch..

@MattWellie MattWellie closed this Mar 15, 2024
@MattWellie MattWellie deleted the update_seqr_minimiser branch March 15, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants