New linter. Readme stickers #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illusional
approved these changes
Feb 5, 2024
| @@ -113,9 +115,9 @@ of all panels on which they have previously been seen. A gene will be treated as | |||
| before, or features in a phenotype-matched panel on which it has not been seen before. i.e. | |||
|
|
|||
| - if a Gene is promoted to `Green` on the Mendeliome, it will be recorded as `New`, and the prior data will be extended | |||
| to show that the gene was seen on the Mendeliome. | |||
| to show that the gene was seen on the Mendeliome. | |||
There was a problem hiding this comment.
IMO, just make this one line, and use soft-wrapping in VSCode:
// in the settings.json
"[markdown]": {
// ... other settings
"editor.wordWrap": "wordWrapColumn",
"editor.wrappingIndent": "same",
"editor.wordWrapColumn": 80,
},There was a problem hiding this comment.
This one was caused by markdownlint... or ruff. One or the other. On-save this got split off back onto separate lines. I've reformatted all markdown files in the repo to remove artificial line breaks
helpers/prepare_aip_cohort.py
Outdated
| @@ -283,7 +283,7 @@ def main( | |||
| logging.info('Pulling all pedigree members') | |||
| pedigree_dicts, ext_lookup = get_pedigree_for_project(project=project) | |||
|
|
|||
| # endpoint gives list of tuples e.g. [['A1234567_proband', 'CPG12341']] | |||
| # endpoint gives list of tuples e.g. [['A1234567_proband', 'CPT12341']] | |||
There was a problem hiding this comment.
You may want to keep the CPG prefix, and make it CPGaaaa so it's clear what the second option is here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
Checklist