Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model correction #351

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Model correction #351

merged 2 commits into from
Jan 18, 2024

Conversation

MattWellie
Copy link
Collaborator

Fixes

  • A couple more changes relating to THE COHORT THAT MUST NOT BE NAMED
  • That project's lack of a -test bucket means no prior data of any form, which has resulted in exercising a few config paths that weren't exposed before

Proposed Changes

  • When running a (now vs. 12 months ago) assessment for new genes, correct the expected data type for the relevant model
  • If there's no historic data location, don't try to save any (tries to open the GCP path None/<file>

Checklist

  • Linting checks pass

@MattWellie MattWellie requested a review from cassimons January 18, 2024 00:04
@cassimons cassimons merged commit c6164d3 into main Jan 18, 2024
5 checks passed
@cassimons cassimons deleted the model_correction branch January 18, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants