Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring of specific categories via config #350

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

MattWellie
Copy link
Collaborator

@MattWellie MattWellie commented Jan 17, 2024

Fixes

Proposed Changes

  • In some situations we may want to run AIP with specific categories removed (e.g. because a label which provides value in trios may generate too much noise in singletons)
  • Instead of tweaking parameters in config, this allows us to completely remove categories from consideration
  • This removal is applied after the Hail/labelling stage, so that blocking/unblocking categories in config is reversible without having to re-run the labelling stage (longest, most expensive part)

Checklist

  • Related Issue created
  • Tests covering new change* (this is tricky in CI, as the whole run uses a single config. I've tested manually, running test_utils.py - this method expects to find a range of labels attached to a variant. When the config entry is amended to remove one of the categories, these asserts break as expected)
  • Linting checks pass

@MattWellie MattWellie requested a review from cassimons January 17, 2024 07:04
@MattWellie MattWellie merged commit f462f6d into main Jan 17, 2024
4 checks passed
@MattWellie MattWellie deleted the 349_disable_categories branch January 17, 2024 07:25
kdahlo pushed a commit to jeremiahwander/automated-interpretation-pipeline that referenced this pull request Jan 17, 2024
)

* Allow for the ignoring of specific categories via config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable categories via config
2 participants