Fix slash typo in /api/v1/sequencing-groupCPGID endpoint #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add '/' so the endpoint is at the intended URL, and correct the return type to avoid it always failing with "that's not a string". Other similar endpoints returning `to_external()` either leave the return type unspecified or return the appropriate external model type like this.
dancoates
approved these changes
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1025 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 188 188
Lines 16369 16369
=======================================
Hits 13499 13499
Misses 2870 2870 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add '/' so the endpoint is at the intended URL, and correct the return type to avoid it always failing with "that's not a string". Other similar endpoints returning
to_external()either leave the return type unspecified or return the appropriate external model type like this.It's easily enough fixed, so we might as well do that rather than delete it.
Fixes SET-386.