-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SET-385 Allow archiving of sequencing groups via metamist api #1020
SET-385 Allow archiving of sequencing groups via metamist api #1020
Conversation
This implementation allows for simple archiving of sequencing groups. While this is not something that needs to happen often, there are cases where sequencing groups are replaced by other samples and are not automatically archived. In those cases it can be necessary to manually archive the sequencing groups and also the sample and analysis. Sample and analysis both already allow their "active" property to be updated so sequencing groups were the odd one out by not allowing deactivation/archiving.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1020 +/- ##
==========================================
+ Coverage 82.92% 82.94% +0.01%
==========================================
Files 191 191
Lines 16758 16788 +30
==========================================
+ Hits 13897 13924 +27
- Misses 2861 2864 +3 ☔ View full report in Codecov by Sentry. |
Thanks so much @dancoates for implementing this so quickly. A note only: we discussed inconsistencies between naming for boolean attributes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Yeah, always tricky to manage backwards compatibility with this sort of stuff, we can't just go through and rename everything to be consistent. Potentially we could support both |
This implementation allows for simple archiving of sequencing groups.
While this is not something that needs to happen often, there are cases
where sequencing groups are replaced by other samples and are not
automatically archived. In those cases it can be necessary to manually
archive the sequencing groups and also the sample and analysis. Sample
and analysis both already allow their "active" property to be updated so
sequencing groups were the odd one out by not allowing
deactivation/archiving.