Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET-385 Allow archiving of sequencing groups via metamist api #1020

Merged

Conversation

dancoates
Copy link
Contributor

This implementation allows for simple archiving of sequencing groups.
While this is not something that needs to happen often, there are cases
where sequencing groups are replaced by other samples and are not
automatically archived. In those cases it can be necessary to manually
archive the sequencing groups and also the sample and analysis. Sample
and analysis both already allow their "active" property to be updated so
sequencing groups were the odd one out by not allowing
deactivation/archiving.

This implementation allows for simple archiving of sequencing groups.
While this is not something that needs to happen often, there are cases
where sequencing groups are replaced by other samples and are not
automatically archived. In those cases it can be necessary to manually
archive the sequencing groups and also the sample and analysis. Sample
and analysis both already allow their "active" property to be updated so
sequencing groups were the odd one out by not allowing
deactivation/archiving.
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (f569d82) to head (ac23d98).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
api/routes/sequencing_groups.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1020      +/-   ##
==========================================
+ Coverage   82.92%   82.94%   +0.01%     
==========================================
  Files         191      191              
  Lines       16758    16788      +30     
==========================================
+ Hits        13897    13924      +27     
- Misses       2861     2864       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amyminiter
Copy link

Thanks so much @dancoates for implementing this so quickly.

A note only: we discussed inconsistencies between naming for boolean attributes for analysis (active) and sg ('archived'. This implementation does maintain those inconsistencies but updating that seems like a larger piece of work for another time.

Copy link

@amyminiter amyminiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@dancoates
Copy link
Contributor Author

A note only: we discussed inconsistencies between naming for boolean attributes for analysis (active) and sg ('archived'. This implementation does maintain those inconsistencies but updating that seems like a larger piece of work for another time.

Yeah, always tricky to manage backwards compatibility with this sort of stuff, we can't just go through and rename everything to be consistent. Potentially we could support both archived and active but as you say it is probably a larger piece of work where we consider the implications of changing the status of each type of entity and how things cascade.

@dancoates dancoates merged commit 5955831 into dev Jan 22, 2025
9 checks passed
@dancoates dancoates deleted the SET-385-allow-archiving-of-sequencing-groups-via-metamist-api branch January 22, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants