Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump submodules #170

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

jokeyrhyme
Copy link
Contributor

  • ran git submodule foreach --recursive 'git fetch; (git checkout master_jammy || git checkout master); (git pull origin master_jammy || git pull origin master);'
  • ran rm -rf ~/.cargo/git ~/.cargo/registry and just clean to make sure I was testing against currently-available commits in GitHub and not something I had cached locally
  • confirmed that just sysext still works
  • end-to-end test from cosmic-greeter into cosmic-session, running Firefox-in-flatpak to create this PR (works)
  • one odd thing I've noticed is that cosmic-term doesn't seem to work when loading it from launcher/desktop, but does load when running it from within alacritty, and there's nothing in journalctl to suggest why

@jokeyrhyme
Copy link
Contributor Author

  • okay, the issue is cosmic-greeter versus cosmic-term, because I can't reproduce the issue when starting the test from gdm
  • I'll raise an issue against cosmic-greeter because I believe it's an environment variable thing

@jackpot51 jackpot51 merged commit 2c660c5 into pop-os:master Jan 7, 2024
1 check passed
@jokeyrhyme jokeyrhyme deleted the bump-submodules-2024-01-07 branch January 7, 2024 05:08
@jokeyrhyme
Copy link
Contributor Author

jokeyrhyme commented Jan 7, 2024

  • I narrowed my cosmic-greeter versus cosmic-term issue down to the wgpu crate having problems with AMDVLK on my system (I have an AMD iGPU and an AMD dGPU, and AMDVLK has poor support for the iGPU)
  • my shell profile sets AMD_VULKAN_ICD=RADV, but this doesn't take effect in greetd the same way it does via gdm
  • AMD_VULKAN_ICD=AMDVLK cosmic-term fails, and AMD_VULKAN_ICD=RADV cosmic-term works
  • I think use login shell rather than reading ~/.profile cosmic-session#23 would fix this on my system, but I have other work arounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants