Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump submodules #158

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

jokeyrhyme
Copy link
Contributor

@jokeyrhyme jokeyrhyme commented Dec 16, 2023

  • ran git submodule foreach --recursive 'git fetch; (git checkout master_jammy || git checkout master); (git pull origin master_jammy || git pull origin master);'
  • ran rm -rf ~/.cargo/git ~/.cargo/registry and just clean to make sure I was testing against currently-available commits in GitHub and not something I had cached locally
  • confirmed that just sysext still works
  • confirmed that loading "COSMIC" from cosmic-greeter results in a functioning session and it does launch, and is able to run alacritty, but not many other apps, see: panic in cosmic-comp @ 6eb8b82 when launching flatpak apps with wayland socket permission cosmic-comp#247
  • it might not even be due to the submodules but something specific to my system

@jokeyrhyme
Copy link
Contributor Author

Okay, the crash is already happening in master, so it's not something introduced here: pop-os/cosmic-comp#247 (comment)

@jokeyrhyme
Copy link
Contributor Author

I've added gtk3 to the CI environment, as cosmic-edit depends upon it at the moment: pop-os/cosmic-edit#11

@jokeyrhyme
Copy link
Contributor Author

Okay, whilst CI is doing its thing, I'm just doing one more end-to-end test from cosmic-greeter, starting a COSMIC session, loading up Firefox in flatpak, and typing this comment, looks great :)

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Drakulix Drakulix merged commit 714d496 into pop-os:master Dec 20, 2023
1 check passed
@jokeyrhyme jokeyrhyme deleted the bump-submodules-2023-12-16 branch December 20, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants