fix duplicate triggers

ponder-sh · Jan 7, 2025 · 7234384 · 7234384
1 parent 0a5645c
commit 7234384
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/.changeset/modern-ads-mate.md b/.changeset/modern-ads-mate.md
@@ -0,0 +1,5 @@
+---
+"ponder": patch
+---
+
+Fixed a bug causing the error: `trigger "_reorg__xyz" for relation "xyz" already exists`.
diff --git a/packages/core/src/database/index.test.ts b/packages/core/src/database/index.test.ts
@@ -648,6 +648,27 @@ test("createTriggers()", async (context) => {
   await database.kill();
 });
 
+test("createTriggers() duplicate", async (context) => {
+  const database = createDatabase({
+    common: context.common,
+    preBuild: {
+      databaseConfig: context.databaseConfig,
+      namespace: "public",
+    },
+    schemaBuild: {
+      schema: { account },
+      statements: buildSchema({ schema: { account } }).statements,
+    },
+  });
+
+  await database.setup({ buildId: "abc" });
+  await database.createTriggers();
+  await database.createTriggers();
+
+  await database.unlock();
+  await database.kill();
+});
+
 test("complete()", async (context) => {
   const database = createDatabase({
     common: context.common,

diff --git a/packages/core/src/database/index.ts b/packages/core/src/database/index.ts
@@ -1032,7 +1032,7 @@ $$ LANGUAGE plpgsql
 
           await sql
             .raw(`
-          CREATE TRIGGER "${tableName.trigger}"
+          CREATE OR REPLACE TRIGGER "${tableName.trigger}"
           AFTER INSERT OR UPDATE OR DELETE ON "${preBuild.namespace}"."${tableName.sql}"
           FOR EACH ROW EXECUTE FUNCTION ${tableName.triggerFn};
           `)