Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws init lint formatting #661

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

justinpolygon
Copy link
Contributor

Attempting to fix lint formatting issue with #658.

@justinpolygon justinpolygon marked this pull request as ready for review April 29, 2024 18:17
@justinpolygon
Copy link
Contributor Author

justinpolygon commented Apr 29, 2024

Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?

@jbonzo
Copy link
Collaborator

jbonzo commented Apr 29, 2024

Hey @jbonzo, I'm facing a dependency deadlock due to the lint check failing against black (23.12.1). I need to merge the current PR to then update the black version to 24.4.2 as required by this PR, which wants a different linting style. Can we merge this PR even if the lint check doesn't pass, or is there a workaround to update the lint check that could resolve this issue? What are your thoughts on proceeding with a merge that doesn't pass the lint check?

@justinpolygon Is there something preventing us from putting the comprehensive fix in this single PR?

@justinpolygon
Copy link
Contributor Author

@justinpolygon Is there something preventing us from putting the comprehensive fix in this single PR?

Doh, that's such a good idea! I just needed a second set of eyes. Yeah, I'll test that. Thank you!

@justinpolygon
Copy link
Contributor Author

That fixed it. Thanks @jbonzo!

@justinpolygon
Copy link
Contributor Author

Thanks again for the suggestion and help @jbonzo! Cheers.

@justinpolygon justinpolygon merged commit e7b4566 into master Apr 29, 2024
9 checks passed
@justinpolygon justinpolygon deleted the jw-fix-ws-init-formatting branch April 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants