Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW6 Качмар Евгений ИТМО ФИТиП #223

Closed
wants to merge 9 commits into from

Conversation

Jenshen30
Copy link
Contributor

No description provided.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28646 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28646 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28646 lines exceeds the maximum allowed for the inline comments feature.

@AlexeyShik AlexeyShik requested review from FedosOnGIT and removed request for AlexeyShik April 29, 2024 07:40
@AlexeyShik AlexeyShik assigned FedosOnGIT and unassigned AlexeyShik Apr 29, 2024
@@ -1,14 +1,12 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это думаю не нужно)


Iterator<EntryWithTimestamp<MemorySegment>> iter =
daoImpl.get(fromString(start),
fromString(request.getParameter("end=")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если end < start, то тоже надо вернуть bad request

Copy link
Contributor

@FedosOnGIT FedosOnGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

окей, 14 баллов. Поставь проверку на то, что end < start и можно повысить

@ghost ghost closed this May 28, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants