HW6 #212
Merged
HW6 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/ru/vk/itmo/test/kovalevigor/config/DaoServerConfig.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/Server.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/ServiceFactoryImpl.java
+fix codeclimate
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| super(new byte[bufferSize], 0, 0, 0); | ||
| this.items = items; | ||
| this.current = items.next(); | ||
| fillBuffer(); |
There was a problem hiding this comment.
Overridable method 'remaining' called during object construction
|
|
||
| private final Iterator<ByteStorage> items; | ||
| private ByteStorage current; | ||
| private int itemOffset = 0; |
There was a problem hiding this comment.
Avoid using redundant field initializer for 'itemOffset'
|
|
||
| private final byte[] data; | ||
|
|
||
| public BaseByteStorage(byte[] data) { |
There was a problem hiding this comment.
The user-supplied array 'data' is stored directly.
| public interface ByteStorage { | ||
|
|
||
| long size(); | ||
| void get(int srcOffset, byte[] dst, int dstOffset, int length); |
There was a problem hiding this comment.
'METHOD_DEF' should be separated from previous statement.
| @@ -98,6 +145,23 @@ private static Response addTimestamp(Response response, TimeEntry<?> entry) { | |||
| return response; | |||
| } | |||
|
|
|||
| private static Session.QueueItem mapEntry(Entry<MemorySegment> entry) { | |||
| long keySize = entry.key().byteSize(); | |||
| long valueSize = entry.value() == null ? 0 : entry.value().byteSize(); | |||
There was a problem hiding this comment.
Use a single space to separate non-whitespace characters.
| public static final MemorySegment CHUNK_LINE_END = MemorySegment.ofArray("\r\n".getBytes(CHARSET)); | ||
| public static final MemorySegment KEY_VALUE_SEP = MemorySegment.ofArray("\n".getBytes(CHARSET)); | ||
| private final List<MemorySegment> chunk; | ||
| public ChunkQueueItem(int bufferSize) { |
There was a problem hiding this comment.
'CTOR_DEF' should be separated from previous statement.
# Conflicts: # src/main/java/ru/vk/itmo/test/kovalevigor/reports/scripts/sh/base.sh # src/main/java/ru/vk/itmo/test/kovalevigor/server/ServiceFactoryImpl.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/ServiceImpl.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/strategy/ServerRemoteStrategy.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/strategy/decorators/AckEitherCompletableFuture.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/strategy/decorators/ServerReplicationStrategyDecorator.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/strategy/decorators/ServerSendResponseStrategyDecorator.java # src/main/java/ru/vk/itmo/test/kovalevigor/server/strategy/util/ServerUtil.java
FedosOnGIT
reviewed
May 13, 2024
|
|
||
| public ChunkQueueItem(int bufferSize) { | ||
| super(bufferSize); | ||
| chunk = new ArrayList<>( |
There was a problem hiding this comment.
А зачем дополнительно в ArrayList засовывать?
There was a problem hiding this comment.
Действительно, нет смысла)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Игорь Ковалев Константинович, M33361