Волков Никита, ИТМО DWS, Stage 6 #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/ru/vk/itmo/test/volkovnikita/HttpServerImpl.java
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
urbanchef
reviewed
May 14, 2024
| appendChunk(output, chunkIterator.next()); | ||
| } | ||
| output.append("0\r\n\r\n".getBytes(StandardCharsets.UTF_8)); | ||
| return connection.write(output.toBytes(), 0, output.length()); |
There was a problem hiding this comment.
Здесь можем не все записать в сокет
"Returns:
The number of bytes written, possibly zero"
urbanchef
reviewed
May 14, 2024
| public synchronized void sendResponse(Response response) throws IOException { | ||
| if (response instanceof ChunkHttpResponse chunkHttpResponse) { | ||
| server.incRequestsProcessed(); | ||
| write(new ChunkQueueItem(chunkHttpResponse)); |
There was a problem hiding this comment.
В случае медленного клиента мы затянем все данные в память и упадем с ООМ, не так ли? В этом случае стриминг не получится. Тут надо обратить внимание на то что под капотом у session.write() (this.queueHead.append(item))
urbanchef
approved these changes
May 14, 2024
|
Сборка не проходит, поэтому не будем мёрджить. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.