Волков Никита, ИТМО DWS, Stage 1 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atimofeyev
requested changes
Feb 25, 2024
|
|
||
| public class HttpServerImpl extends HttpServer { | ||
|
|
||
| private final ReferenceDao dao; |
There was a problem hiding this comment.
тут лучше определять интерфейсом
| if (isIdCorrect(id)) { | ||
| return new Response(Response.BAD_REQUEST, Response.EMPTY); | ||
| } | ||
| MemorySegment key = idToMemorySegment(id); |
There was a problem hiding this comment.
одно поле получается через вызов метода, а второй прямо тут через MemorySegment, для чистоты кода лучше делать одинаково
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<Void> stop() throws IOException { |
There was a problem hiding this comment.
старт/стоп лучше синхронизированными сделать
atimofeyev
approved these changes
Mar 1, 2024
osokindm
pushed a commit
to osokindm/2024-highload-dht
that referenced
this pull request
Mar 6, 2024
* init commit * data research result * result * refactoring --------- Co-authored-by: atimofeyev <[email protected]>
axothy
pushed a commit
to axothy/2024-highload-dht
that referenced
this pull request
Mar 13, 2024
* init commit * data research result * result * refactoring --------- Co-authored-by: atimofeyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.