Skip to content
This repository has been archived by the owner on Mar 3, 2024. It is now read-only.

тесты на Windows #152

Merged
merged 7 commits into from
Nov 25, 2023
Merged

тесты на Windows #152

merged 7 commits into from
Nov 25, 2023

Conversation

osokindm
Copy link
Contributor

No description provided.

@osokindm
Copy link
Contributor Author

Описание

@osokindm
Copy link
Contributor Author

PersistentTest проверял на втором дз, проходили все тесты, кроме cleanUp()

@@ -45,6 +45,7 @@ void variability(Dao<String, Entry<String>> dao) throws IOException {
for (final Entry<String> entry : entries) {
assertSame(dao.get(entry.key()), entry);
}
dao.close();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тест cleanup() ниже поломан.

@incubos incubos requested a review from Artyomcool October 17, 2023 14:34
@incubos incubos requested a review from a user October 17, 2023 14:34
@incubos incubos assigned ghost Oct 17, 2023
@Artyomcool
Copy link
Contributor

Боюсь, если тесты не работают, то принять PR мы не можем.

@incubos
Copy link
Member

incubos commented Oct 20, 2023

Внезапно тесты починились :)

@Artyomcool
Copy link
Contributor

Предлагаю тогда замёржить и накинуть 10 баллов за инициативу.

@incubos incubos merged commit 3e6350e into polis-vk:main Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants