Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Do not require authentication to view documentation #4689

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

magarpratik
Copy link
Contributor

Closes #4637

This PR implements logic to ensure authentication is not required to view documentation.

Copy link

vercel bot commented Dec 18, 2024

@magarpratik is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

@frankie567
Copy link
Member

frankie567 commented Dec 19, 2024

Hmm, I've just checked and was able to access to docs.polar.sh or 127.0.0.1:3000/docs unauthenticated without any problem.

Under which circumstances did you hit this problem?

Never mind, should have read the issue first 😅 I'll have a closer look

@frankie567
Copy link
Member

Ok, I get it now 👍 The problem comes from the fact that, on docs.polar.sh, we redirect pages like /docs/finance/balance to /finance/balance, which then falls under the authenticated route.

Not 100% sure the .startsWith('/docs/') is necessary, but that'll be good enough for now!

Thank you again @magarpratik 👍

@frankie567 frankie567 merged commit af55df2 into polarsource:main Dec 19, 2024
4 of 7 checks passed
@magarpratik magarpratik deleted the docs/do-not-require-auth branch December 19, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Some pages return 404 if user is not logged in
2 participants