Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.commit() and unit tests cleanup #4678

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

frankie567
Copy link
Member

No description provided.

@frankie567 frankie567 enabled auto-merge (rebase) December 18, 2024 14:15
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
polar ⬜️ Ignored (Inspect) Dec 18, 2024 2:18pm
polar-sandbox ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 2:18pm

This can hurt the idempotency of our tasks and consistency in DB.
Was not really working anymore + didn't prove very useful
This made writing tests really painful and didn't bring much value
@frankie567 frankie567 force-pushed the fix/remove-unnecessary-commits branch from 1040702 to a08d359 Compare December 18, 2024 14:17
Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@frankie567 frankie567 merged commit 52a062b into main Dec 18, 2024
11 checks passed
@frankie567 frankie567 deleted the fix/remove-unnecessary-commits branch December 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant