Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always pass bytes in the RDKitMolCodec #261

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

cwognum
Copy link
Collaborator

@cwognum cwognum commented Jan 31, 2025

Changelogs

  • Always pass bytes to the VLenBytes codec, parent class of the RDKitMolCodec.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

I was running into a Cython issue with a chunk size > 1 because we were passing None rather than bytes.

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Jan 31, 2025
@cwognum cwognum self-assigned this Jan 31, 2025
Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cwognum cwognum merged commit f64bcdc into main Feb 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants