Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up error handling around Hub client requests #253

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

jstlaurent
Copy link
Contributor

Changelogs

  • Simplify error handling around requests to the Polaris Hub
  • Wrap lower-level errors in PolarisHubError, to have more helpful messages

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • {Update the API documentation if a new function is added, or an existing one is deleted.~
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

I noticed that we had some type incompatibilities when instanciating PolarisHubError, around the response object passed in. I corrected this, and took the opportunity to simplify and straighten
up the error handling around the client's requests to the Hub. It should now do a better job at surfacing PolarisHubError, which have nicer user facing messages than the underlying errors.

@jstlaurent jstlaurent force-pushed the chore/error-handling-cleanup branch from d146221 to c682c98 Compare January 23, 2025 18:40
Copy link
Contributor

@mercuryseries mercuryseries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jstlaurent 💅!

@jstlaurent jstlaurent force-pushed the chore/error-handling-cleanup branch from 86b9c97 to 39f39c3 Compare January 23, 2025 19:45
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jstlaurent !

@jstlaurent jstlaurent merged commit 66fb428 into main Jan 24, 2025
19 checks passed
@jstlaurent jstlaurent deleted the chore/error-handling-cleanup branch January 24, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants