Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a CI job to run tests in Conda, to detect dependency failure earlier #245

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jstlaurent
Copy link
Contributor

Changelogs

  • Add a GitHub Actions job to run the test suite under a Conda environment
  • Update the dependency list by removing unused ones

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

Since we've been tripped by some dependendencies that don't have all platforms supported in Conda, adding a CI flow that will run the tests from a clean Conda environment should raise these issues earlier.

Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

Random thought: As the CICD continues to grow, is there value in changing to a different service (e.g. I think I've seen @Andrewq11 use CodeFresh). I have never actually worked with such services, so I'm not sure it's worth it.

Copy link
Contributor

@Andrewq11 Andrewq11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @jstlaurent.

It would've been nice to do this test on conda-forge's CI infrastructure. That was the original thought, but apparently we cannot reliably get access to non-Linux runners for testing there.

No issue though, this will be great for avoiding any further upstream dependency hiccups 🚀

Copy link
Contributor

@mercuryseries mercuryseries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jstlaurent!

@jstlaurent jstlaurent force-pushed the chore/conda-ci branch 2 times, most recently from f7432cb to 7478a93 Compare January 14, 2025 20:39
@jstlaurent jstlaurent merged commit f358bf2 into main Jan 14, 2025
19 checks passed
@jstlaurent jstlaurent deleted the chore/conda-ci branch January 14, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants