-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for handling Benchmarks V2 #234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… V2 implementations. Add Pydantic models for the V2 split, and V2 validations.
… everything stays coherent. Serialize the artifact version when dumping a model. Various fixes.
cwognum
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jstlaurent and @mercuryseries ! This is looking good! 🚀
mercuryseries
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @jstlaurent! I added some minor comments here and there.
try:
while True:
print("Thank you! (Until Julien is tired)")
except KeyboardInterrupt:
print("Gratitude interrupted, but it’s endless in spirit! :)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
BenchmarkSpecification
into an abstract class, withBenchmarkV1Specification
andBenchmarkV2Specification
implementations. The abstract class defines a series of abstract methods and propertiesfor the subclasses to implement.
mode="before"
ensure that we convert the input to asingle internal representation.
Checklist:
feature
,fix
,chore
,documentation
ortest
(or ask a maintainer to do it for you).The core changes are ready for review. I need to add some tests and ensure the doc is updated as well.