Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add alias for custom_name in Metric #233

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix: Add alias for custom_name in Metric #233

merged 2 commits into from
Dec 12, 2024

Conversation

cwognum
Copy link
Collaborator

@cwognum cwognum commented Dec 12, 2024

Changelogs

  • Add an alias to the custom_name to match behavior on Hub.
  • Clarify error message

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

I'll merge this without review given the urgency.

@cwognum cwognum added the fix Annotates any PR that fixes bugs label Dec 12, 2024
@cwognum cwognum self-assigned this Dec 12, 2024
@cwognum cwognum changed the title Fixed naming for metrics Fix: Add alias for custom_name in Metric Dec 12, 2024
@cwognum cwognum merged commit ff0bb3b into main Dec 12, 2024
10 checks passed
@cwognum cwognum deleted the fix/metric-naming branch December 12, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Annotates any PR that fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant