[Tokenomics][Tests in Progress] Integrate SessionAccounting w/ Claim & Proof lifecycle #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Bryan White <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
e2e/tests/stake.feature
Outdated
| @@ -8,9 +8,10 @@ Feature: Stake Namespaces | |||
| Then the user should be able to see standard output containing "txhash:" | |||
| And the user should be able to see standard output containing "code: 0" | |||
| And the pocketd binary should exit without error | |||
| And the user should wait for "5" seconds | |||
| # TODO_IN_THIS_PR: Add a comment explaining | |||
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
# TODO_IN_THIS_PR: Add a comment explaining
…roof-integration * pokt/feat/proof-validation: chore: Add godoc comments chore: Update keeper query clients in-code documentation chore: Address review change requests [PubKeyClient] Implement PubKeyClient for on/off-chain usage (#413)
… test/proof-integration
…roof-integration * pokt/feat/proof-validation: fix: test error msg assertion
(cherry picked from commit eab6d984e65a9a07014c9a9839e7b55d125147a1)
11 tasks
Olshansk
force-pushed
the
issues/359/integrate_session_accounting_with_cnp_attempt_2
branch
from
1c4d354 to
d9924ec
Compare
…sion_accounting_with_cnp_attempt_2
Olshansk
changed the title
|
Superseded by #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Settle Claim Expiration.
Issue
Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist