Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supplier] refactor: claim & proof protobufs + #263

Merged
merged 17 commits into from
Jan 10, 2024
Merged

[Supplier] refactor: claim & proof protobufs + #263

merged 17 commits into from
Jan 10, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 12, 2023 •
edited
Loading

Summary

Human Summary

  • Refactor claim and proof protobuf types to use SessionHeader.
  • Rename supplier keeper methods to UpsertClaim() and UpsertProof().
  • Misc. claim-side improvements.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic code health Cleans up some code labels Dec 12, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Dec 12, 2023
@bryanchriswhite bryanchriswhite self-assigned this Dec 12, 2023
@bryanchriswhite bryanchriswhite mentioned this pull request Dec 12, 2023
Closed
10 tasks
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from 17e1b7e to 9a59011 Compare December 12, 2023 17:09
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Dec 13, 2023
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from 99fa69b to b58e75d Compare December 13, 2023 10:52
This was linked to issues Dec 13, 2023
[Proof] Update post-scaffolding for the Proof type #228
Closed
[Protocol] MVP implementation off the on-chain SubmitProof message handling #141
Closed
@bryanchriswhite bryanchriswhite removed devnet-test-e2e push-image CI related - pushes images to ghcr.io devnet labels Dec 13, 2023
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/testutil branch from 6fb3362 to 4bcd8de Compare December 13, 2023 14:00
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from b58e75d to d069306 Compare December 13, 2023 14:01
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/claim-proof branch from d069306 to ef3cd99 Compare December 13, 2023 21:00
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 13, 2023 21:02
@bryanchriswhite bryanchriswhite changed the title [On-chain, Code Health] refactor: claim & proof protobufs + [Supplier] refactor: claim & proof protobufs + Dec 14, 2023
@bryanchriswhite bryanchriswhite added the supplier Changes related to the Supplier actor label Dec 14, 2023
red-0ne
red-0ne approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Had just one question to refine my understanding of how it's working

x/supplier/keeper/proof.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jan 8, 2024
@bryanchriswhite
chore: add TODO
3de1971
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/141/refactor/cla…
800b53b 
…im-proof

* pokt/main:
  [SMT] Path Bump to v0.8.2 (#305)
  [Configs] feat: Add stake amount to supplier staking config (#300)
  [Configs] feat: Add stake amount in the app stake config (#299)
@bryanchriswhite bryanchriswhite mentioned this pull request Jan 9, 2024
Closed
11 tasks
Olshansk
Olshansk approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small NIT.

@bryanchriswhite Please make sure to validate e2e tests before merging!

x/supplier/client/cli/query_claim.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

@bryanchriswhite bryanchriswhite dismissed h5law’s stale review January 10, 2024 12:20

Feedback addressed. 🫡

@bryanchriswhite bryanchriswhite merged commit 727b0ef into main Jan 10, 2024
10 checks passed
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Jan 10, 2024
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/141/refactor/cla…
c648d4f 
…im-proof

* pokt/main:
  [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
@bryanchriswhite
Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…
c00e1b2 
…ctor/supplier-errors

* issues/141/refactor/supplier-keys:
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
@bryanchriswhite
Merge branch 'issues/141/refactor/supplier-errors' into issues/141/pr…
dd5ea83 
…ep/in-memory-network

* issues/141/refactor/supplier-errors:
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
bryanchriswhite added a commit that referenced this pull request Jan 10, 2024
@bryanchriswhite
Merge branch 'issues/141/prep/in-memory-network' into issues/141/feat…
b0b0436 
…/in-memory-network

* issues/141/prep/in-memory-network:
  [Testing, Tooling] chore: in-memory network interface & config types (#289)
  trigger CI
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
  chore: review feedback improvements
  [Configs] feat: Add staking config parser of gateway staking (#302)
  chore: review feedback improvements
  fix: usage raw string literal
  chore: review feedback improvements
  [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite added a commit that referenced this pull request Jan 12, 2024
@bryanchriswhite
Merge branch 'issues/141/feat/in-memory-network' into issues/141/refa…
0778128 
…ctor/in-memory-network

* issues/141/feat/in-memory-network:
  chore: review feedback improvements
  feat: update SMT to v0.9.2 (#311)
  fix: linter errors
  fixup! chore: review feedback improvements
  chore: review feedback improvements
  chore: review feedback improvements
  [Testing, Tooling] chore: in-memory network interface & config types (#289)
  trigger CI
  [Supplier] refactor: supplier module errors (#265)
  [Supplier] refactor: supplier module keys (#264)
  [Supplier] refactor: claim & proof protobufs + (#263)
  chore: review feedback improvements
  [Configs] feat: Add staking config parser of gateway staking (#302)
  chore: review feedback improvements
  fix: usage raw string literal
  chore: review feedback improvements
  [RingCache] Invalidate Cache On Redelegation Events (#239)
okdas pushed a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite @h5law @Olshansk
[Supplier] refactor: claim & proof protobufs + (#263)
6b67ff9 
* refactor: `NewMinedRelay` to shared testutil

* refactor: claim & proof protobuf types

* refactor: rename supplier keeper `UpsertClaim` & `UpsertProof`

* refactor: misc. claim-side improvements

* chore: add TODOs

* chore: review feedback improvements

Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: harry <[email protected]>

* chore: add TODOs

* trigger CI

* chore: add TODO

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>

* fix: usage raw string literal

---------

Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

@Olshansk Olshansk Olshansk approved these changes

@h5law h5law Awaiting requested review from h5law

Assignees

@bryanchriswhite bryanchriswhite

Labels
code health Cleans up some code on-chain On-chain business logic supplier Changes related to the Supplier actor
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
4 participants
@bryanchriswhite @red-0ne @Olshansk @h5law