-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Supplier] Scaffold the Proof
type and adjust some of the defaults
#197
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1780b1b
Add a comment on scaffolding
Olshansk 1745b6a
ignite scaffold map proof --module supplier supplier_address session_…
Olshansk a0e9e8d
Remove proof list
Olshansk 9a9ca7a
Fix grammer for AllProof querying
Olshansk 7400fad
Merge with main
Olshansk 190fd3c
Update openapi.yml file
Olshansk fef0851
Update formatting
Olshansk cd58d0f
Merge branch 'main' into issues/141/scaffold_proof_type
Olshansk e3340f7
Ran make go_imports
Olshansk 3b491a5
Update go.mod
Olshansk b680d9c
Update x/supplier/client/cli/query_proof.go
Olshansk 33f7fd1
Update x/supplier/client/cli/query_proof_test.go
Olshansk cede36c
[Supplier] feat: Add staking flag and config parser (#185)
red-0ne df6ee28
[Miner] test: add `#MinedRelays()` coverage (#191)
bryanchriswhite 6a21392
chore: omitted improvments to #191 (#214)
bryanchriswhite ef7afb5
Follow up on review comments
Olshansk 7dfd86c
A couple more nites
Olshansk d72738b
Merge with main
Olshansk bdf0ee9
Manually ran goimports -w -local github.com/pokt-network/poktroll on …
Olshansk 13ec4cb
Merge branch 'main' into issues/141/scaffold_proof_type
Olshansk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
syntax = "proto3"; | ||
package pocket.supplier; | ||
|
||
option go_package = "github.com/pokt-network/poktroll/x/supplier/types"; | ||
|
||
// TODO_UPNEXT(@Olshansk): The structure below is the default (untouched) scaffolded type. Update | ||
Olshansk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// and productionize it for our use case. | ||
message Proof { | ||
string index = 1; | ||
string supplier_address = 2; | ||
string session_id = 3; | ||
string merkle_proof = 4; | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good time for a bash script IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat tangential: I would like to propose that we entertain the idea of preferring to write scripts in go. I think the stdlib is more than capable on it's own to accomplish most scripting needs. While it may be verbose in some cases, I think minimizing the number of languages in the repo is worth it on the whole.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pantani responded to it, so I want to see if we can solve it via the ignite path first before investing time into it writing proprietary scripts.