[RelayRequest] Don't Unmarshal Request Payloads

[h5law]

Summary

Human Summary

• replace request payloads with []byte and dont unmarshal them

AI Summary

Summary generated by Reviewpad on 14 Nov 23 22:53 UTC

This pull request introduces a feature that generalizes the parameters in the JSON RPC request to be either maps or lists. It modifies multiple files to implement this feature.

Issue

• Fixes N/A

Type of change

Select one or more:

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Documentation
• Other (specify)

Testing

• Run all unit tests: make go_develop_and_test
• Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

• I have tested my changes using the available tooling
• I have performed a self-review of my own code
• I have commented my code, updated documentation and left TODOs throughout the codebase

[Olshansk]

Asking a pretty big structural question before moving on.

[Olshansk]

Suggested change

	// excludes the params field, which is unmarshaled sperately.
	// excludes the params field, which is unmarshaled separately.
	// This is used because the proto object cannot be unmarshalled directly, so this is a
	// temporary object to be used interim.

[Olshansk]

Does the struct and its types need to be exposed publically?

[Olshansk]

I thought about it and realized this could be a string of objects: [obj1, obj2, etc..].

Wdyt of just making prams an Any like you suggested in discord?

[h5law]

@Olshansk I think an approach could be storing the payload as its bytes. And just passing these directly. The downside of this is what if we wanted to do compute units?

Answer: we interim unmarshal without the params as compute units should probably only depend on the method being called (params shouldn't affect the method as the method's "weighting" would factor in the types of params it receives) and assign the weighting that way.

The reason I am against using Any in the protobuf is that the protobuf Any isn't 1-1 correspondance with the go any ie we cannot unmarhsal any type into an Any an any needs to be an Any type in go which the unmarhsaling step would again require some interim step of unmarshaling without the params and then a longer type checking.

Overall I think us trying to proto-ify the payload is probably the wrong path. What do we need it to be a protobuf for? Why cant be just directly pass the payload from the request to the service? Personally I think making the payload a protobuf is not for us to deal with - as we dont do anything with it, unlike the other field of the request structure.

WDYT?