Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Supplier] Scaffold the Claim type #149

Merged
merged 18 commits into from
Nov 8, 2023
Merged

[Supplier] Scaffold the Claim type #149

merged 18 commits into from
Nov 8, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Nov 6, 2023 •
edited
Loading

Summary

Ran the following command and nothing else:

ignite scaffold map claim --module supplier supplier_address session_id root_hash --no-message --yes

Issue

[Explain the reasoning for the PR in 1-2 sentences. Consider adding a link or a screenshot.]

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk self-assigned this Nov 6, 2023
@Olshansk Olshansk added the supplier Changes related to the Supplier actor label Nov 6, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Nov 6, 2023
@Olshansk Olshansk force-pushed the issues/140/scaffold_claim branch from a0f2418 to 21b55c6 Compare November 7, 2023 00:15
@Olshansk Olshansk mentioned this pull request Nov 7, 2023
Merged
10 tasks
h5law
h5law suggested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments around naming and plurality - these seem to be ignite issues tho 👍🏼

Olshansk and others added 10 commits November 7, 2023 14:45
@Olshansk @bryanchriswhite
Update x/supplier/client/cli/query_claim.go
2562c90 
Co-authored-by: Bryan White <[email protected]>
@Olshansk @h5law
Update x/supplier/client/cli/query_claim.go
369db38 
Co-authored-by: harry <[email protected]>
@bryanchriswhite @Olshansk
[Miner] feat: add TxClient (#94)
3f6e68a 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update

* chore: review feedback improvements

* docs: update client README.md

* docs: add `tx query` usage association between `txContext` & `Blockchain`

* docs: add TOC

* chore: review feedback improvements

Co-authored-by: Daniel Olshansky <[email protected]>

* docs: improve godoc comments & client README.md

---------

Co-authored-by: Daniel Olshansky <[email protected]>
@bryanchriswhite @Olshansk
[Off-chain] refactor: keyring errors & helpers (#131)
3c4401c 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* refactor: consolidate keyring errors & helpers

* refactor: keyring test helpers

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update
@bryanchriswhite @Olshansk
[Miner] feat: add supplier client (#42)
d67edee 
* chore: add `TxClient` interface

* chore: add option support to `ReplayObservable`

* feat: add `txClient` implementation

* test: `txClient`

* test: tx client integration

* chore: s/tx/transaction/g

* chore: update pkg README.md template

* wip: client pkg README

* docs: fix client pkg godoc comment

* refactor: consolidate keyring errors & helpers

* refactor: keyring test helpers

* fix: flakey test

* chore: dial back godoc comments 😅

* chore: add `SupplierClient` interface

* feat: add supplier client implementation

* test:  supplier test helpers

* test: supplier client tests

* test: supplier client integration test

* chore: update go.mod

* trigger CI

* chore: revise (and move to godoc.go) `testblock` & `testeventsquery` pkg godoc comment

* chore: update go.mod

* chore: refactor & condense godoc comments

* chore: fix import paths post-update

* chore: add godoc comment
@bryanchriswhite @Olshansk
[Testing, Docs] refactor: move /internal/... to /testutil/... for god…
13479cf 
…ocs (#153)

* refactor: move /internal pkgs to /testutil

* chore: cleanup
@Olshansk
Tend to review comments
afa624f
@Olshansk
Merge branch 'main' into issues/140/scaffold_claim
fef7af6
@Olshansk
Fixing whitespace
ca62bb2
@Olshansk
Fixed the last broken test
15b5fb3
bryanchriswhite
bryanchriswhite approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving to streamline merging (this week).

I noticed a few more things since my last review; apologies if some of them were there previously and I just missed them. 😅

@Olshansk Olshansk merged commit b39195a into main Nov 8, 2023
7 checks passed
@Olshansk Olshansk deleted the issues/140/scaffold_claim branch November 8, 2023 20:46
@Olshansk Olshansk mentioned this pull request Nov 27, 2023
Closed
6 tasks
okdas pushed a commit that referenced this pull request Nov 14, 2024
@Olshansk @bryanchriswhite @h5law
[Supplier] Scaffold the Claim type (#149)
a4fa181 
Ran the following command and nothing else:
```
ignite scaffold map claim --module supplier supplier_address session_id root_hash --no-message --yes
```


---

Co-authored-by: Bryan White <[email protected]>
Co-authored-by: harry <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

@h5law h5law Awaiting requested review from h5law

Assignees

@Olshansk Olshansk

Labels
supplier Changes related to the Supplier actor
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
3 participants
@Olshansk @bryanchriswhite @h5law