[Morse->Shannon Migration] scaffold: MorseAccountState single
#1045
Conversation
bryanchriswhite
added
on-chain
bryanchriswhite
force-pushed
the
issues/1034/scaffold/morse_account_state
branch
from
89b83f7 to
b720680
Compare
bryanchriswhite
force-pushed
the
issues/1034/scaffold/morse_account_state
branch
from
b720680 to
cf4a0c5
Compare
|
|
||
| val, found := k.GetMorseAccountState(ctx) | ||
| if !found { | ||
| return nil, status.Error(codes.NotFound, "not found") |
There was a problem hiding this comment.
Can we do some logging here as well?
There was a problem hiding this comment.
To what end, can you elaborate?
| @@ -0,0 +1,48 @@ | |||
| package keeper_test | |||
There was a problem hiding this comment.
NOTE: I'm skiping reviewing unit tests in leu of time.
| } | ||
| } | ||
|
|
||
| func (msg *MsgCreateMorseAccountState) ValidateBasic() error { |
There was a problem hiding this comment.
Do we not need to validate morseAccountState?
There was a problem hiding this comment.
Did you have something specific in mind? I've add a hash comparison in #ValidateBasic(), but I'm reluctant to add logic that requires iterating over all accounts for similar reasons as mentioned elsewhere (performance). This seems redundant to me regardless, so long as we intend to rely on off-chain verification/consensus.
We should be able to assume the validity because it's generated from the new migrate sub-command and should be deterministically reproducible and should have social consensus prior to being created on-chain in Shannon.
| message QueryGetMorseAccountStateRequest {} | ||
|
|
||
| message QueryGetMorseAccountStateResponse { |
There was a problem hiding this comment.
E2E test for this? Doesn't have to be in this PR.
There was a problem hiding this comment.
We have unit/integration coverage over this.
…orse_account_state
Summary
Scaffolds the on-chain
MorseAccountStatesingle as well as a create message/query handlers. Supersedes #1035.Changes:
Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI