Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Implement onchain cache #1023

Closed
wants to merge 21 commits into from

Conversation

red-0ne
Copy link
Contributor

@red-0ne red-0ne commented Jan 9, 2025

Summary

Implements a caching mechanism to reduce disk access by the KV store.

Issue

In order to improve onchain scalability, it was noticed that settling pending claims puts a lot of pressure on disk IO.

image

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

red-0ne and others added 20 commits December 11, 2024 17:53
This pull request includes several changes to the `pkg/client` package,
focusing on adding gas limit and gas price parameters to transaction
signing and broadcasting functions, as well as making related updates in
tests and configurations.

It also updates the `BroadcastTx` method in `pkg/client/tx/context.go`
to use `BroadcastTxSync` instead of `BroadcastTxAsync` for better error
handling during the check-tx ABCI operation.

Minor Fix: Changed the URL in `makefiles/relay.mk` to include a trailing
slash.

![image](https://github.com/user-attachments/assets/535e99b3-621b-46bd-a335-49e167c50cba)

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
- [x] Bug fix
- [ ] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

- [ ] **Documentation**: `make docusaurus_start`; only needed if you
make doc changes
- [x] **Unit Tests**: `make go_develop_and_test`
- [x] **LocalNet E2E Tests**: `make test_e2e`
- [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR.

- [x] I have tested my changes using the available tooling
- [x] I have commented my code
- [x] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [x] I have left TODOs throughout the codebase, if applicable

---------

Co-authored-by: Dima K. <[email protected]>
Co-authored-by: Dmitry K <[email protected]>
@red-0ne red-0ne added on-chain On-chain business logic code health Cleans up some code loadtest Work related to load testing scalability labels Jan 9, 2025
@red-0ne red-0ne added this to the Beta TestNet Iteration milestone Jan 9, 2025
@red-0ne red-0ne self-assigned this Jan 9, 2025
@red-0ne red-0ne force-pushed the feat/onchain-cache branch from 3af360b to f566510 Compare January 9, 2025 02:39
@red-0ne red-0ne changed the base branch from fix/revamp-loadtest to feat/proof-endblocker January 17, 2025 17:09
@red-0ne
Copy link
Contributor Author

red-0ne commented Jan 27, 2025

Closing in favor of #1038

@red-0ne red-0ne closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code loadtest Work related to load testing on-chain On-chain business logic scalability
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant